[PATCH] comctl32/listview: Derive subitem rect from listview origin
Nikolay Sivov
bunglehead at gmail.com
Mon May 17 18:19:59 CDT 2010
On 5/18/2010 02:36, Andrew Eikum wrote:
>
> The old code used the containing item's position to determine the
> subitem's rect. Instead, we should be using the entire listview's
> origin as the offset, since the item position can change as columns
> are inserted and re-arranged, leading to broken listviews.
> ---
> dlls/comctl32/listview.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Looks right. Seems to be (one?) of remaining problem that comes out
after I added column reordering.
Please add a minimal test case for this to prevent a regression. All you
need - add 2 columns, add item,
reorder columns with a LVM_SETCOLUMNORDERARRAY and test rectangle.
More information about the wine-devel
mailing list