[PATCH] ntdll: Use the old mmap() wrapper on 32-bit Mac OS. (try 3)

[James McKenzie]

Charles Davis wrote:
> On 5/17/10 8:13 PM, James McKenzie wrote:
>   
>> Alexandre Julliard wrote:
>>     
>>> Charles Davis <cdavis at mymail.mines.edu> writes:
>>>
>>>  
>>>       
>>>> What's wrong with my patch now? It's a really simple fix; in fact, this
>>>> is as about as simple as it gets. How does this "break libwine
>>>> compatibility"?
>>>>     
>>>>         
>>> Like I said, it's not worth the trouble. Most modules need to be
>>> relocated anyway. It would have to be done in the kernel.
>>>
>>>   
>>>       
>> AJ:
>>
>> kernel32.dll or the OS kernel?  It is quite an effort to get patches
>> into the MacOSX kernel, but it CAN BE DONE.
>>     
> I think he's referring to the system kernel, not the Win32 Kernel API
> (kernel32.dll).
>
> Personally, I prefer making kexts instead of modifying the kernel
> itself, but if I absolutely have to, I can change the kernel.
>
>   
Is this something that should be investigated by the Open/Free-BSD (I 
cannot keep which version MacOSX is based upon) community for inclusion 
into the base kernel?

If it is not, then it should be something under consideration by the 
Wine project.  Hacking the kernel to make one program work is not a 
'best practice'.

James McKenzie