wininet: Combine certificate errors in HTTP_OpenConnection

Dan Kegel dank at kegel.com
Wed May 19 08:19:00 CDT 2010


On Wed, May 19, 2010 at 5:27 AM, Piotr Caban <piotr.caban at gmail.com> wrote:
>> Or look at how Chromium does its ssl unit tests, by launching a little
>> server written in python:
>>
>> http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=net/socket/ssl_test_util.cc
>>
>> http://src.chromium.org/cgi-bin/gitweb.cgi?p=chromium.git;a=blob;f=net/socket/ssl_client_socket_unittest.cc
>
> I don't see a good reason for writing small http server in tests. It's a lot
> of work.

No, you don't have to write it, you can just use a canned
python server.  It isn't a lot of work.

> Certificate verification errors can be checked in crypt32 tests, it
> can be done locally (there are already some tests).

Of course, if you can avoid having a server at all, that's the best.
But there are some tests that currently fail if you're not online,
and that's bad.
- Dan



More information about the wine-devel mailing list