d3dx: should NULL defines be accepted?

Luis Busquets luis.busquets at ilidium.com
Thu May 27 23:40:32 CDT 2010


The current code for the functions:

D3DXCreateEffectFromFileExW  <http://source.winehq.org/ident?i=D3DXCreateEffectFromFileExW>
D3DXCreateEffectFromFileExA  <http://source.winehq.org/ident?i=D3DXCreateEffectFromFileExA>
D3DXCreateEffectFromResourceExW  <http://source.winehq.org/ident?i=D3DXCreateEffectFromResourceExA>
D3DXCreateEffectFromResourceExA  <http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileW>
D3DXCreateEffectCompilerFromFileW  <http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileW>
D3DXCreateEffectCompilerFromFileA  <http://source.winehq.org/ident?i=D3DXCreateEffectCompilerFromFileA>

includes a check of defines and will returnD3DERR_INVALIDCALL  <http://source.winehq.org/ident?i=D3DERR_INVALIDCALL>  if defines are NULL.

However I see nothing wrong in calling any of those functions with defines  being NULL. Actually, usually defines are NULL and it is only in specific cases when they are set.

Is this a bug? If not, please let me know why.

regards,



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100528/54254c55/attachment.htm>


More information about the wine-devel mailing list