Last Minute Submission: Winecfg>About

[André Hentschel]

Am 29.05.2010 17:17, schrieb Joel Holdsworth:
> Hi All,
> 
> I know it's late and we're in freeze mode now, but I wanted to offer
> some work I've been doing:
> 
> http://www.airwebreathe.org.uk/space/new-about-screen.png
> 
> Basically I've been giving the about page of winecfg a face lift. It
> seemed like a good idea to put some polish on it in time for the
> release. Is there any interest in pushing this? or is it too late?

As Nikolay said, it is safe.

> The patches are all fairly straightforward. The only gotcha is that the
> modification to the page layout has to be carried across all languages
> without introducing any errors. I'm planning to do this with a simple
> script, but is there a simple way of switching between languages
> quickly? So I can check the layout doesn't get broken?
> 
> Also, if I submit these patches - to be merged now or later, would it be
> better to submit all the resource language patches inidividually? or
> language by language?
> 
> What do people think?

First: Good idea and great job! It goes with the new Icons.

Like Nikolay i am a bit scared of the link control. Maybe that should not be included in the first patch and you can send it later when it surely works.
Against Nikolay's opinion i think you didnt changed the layout too much(compared one by one) so it is ok.


-- 

Best Regards, André Hentschel