Last Minute Submission: Winecfg>About

Joel Holdsworth joel at airwebreathe.org.uk
Sun May 30 10:55:29 CDT 2010


Yeah the link control doesn't work. I think the problem is with
shell32/shlexec.c. I get the attached output when I try with WINEDEBUG=
+exec . For some reason it seems to be appending a backslash on the end
of the URL. It looks like a very simple problem to fix. If you run "wine
winebrowser http://www.winehq.org" on the command line, you get native
firefox. ...but then if you run wine "winebrowser http://www.winehq.org\
\" - with an escaped backslash it works just as well; worth
investigating.

Even if we don't get it fixed in time, I think the link is worth having
- even if just for purely aesthetic reasons.

Joel

--------------------
trace:exec:ShellExecuteA
(nil),"open","http://www.winehq.org",(null),(null),5
trace:exec:ShellExecuteExA 0x32d084
trace:exec:SHELL_execute mask=0x00000400 hwnd=(nil) verb=L"open"
file=L"http://www.winehq.org" parm=(null) dir=(null) show=0x00000005
class=not used
trace:exec:ShellExecute_FromContextMenu L"http://www.winehq.org"
trace:exec:ShellExecute_GetClassKey ext = L".org"
trace:exec:SHELL_execute execute:L"http://www.winehq.org",L"",L""
trace:exec:SHELL_ExecuteW Execute L"http://www.winehq.org" from
directory L""
trace:exec:SHELL_ExecuteW returning 2
trace:exec:SHELL_FindExecutable L"http://www.winehq.org"
trace:exec:SHELL_FindExecutable Returning SE_ERR_FNF
trace:exec:SHELL_execute_url Got URL: L"http://www.winehq.org"
trace:exec:execute_from_key L"http\\shell\\open\\command"
L"http://www.winehq.org" (null) L"" L""
trace:exec:execute_from_key got cmd: L"C:\\windows\\system32\
\winebrowser.exe -nohome"
trace:exec:SHELL_ArgifyW 0x328720, 1024, L"C:\\windows\\system32\
\winebrowser.exe -nohome", L"http://www.winehq.org", (nil), 0x32c004
trace:exec:SHELL_ArgifyW used 43 of 1024 space
trace:exec:execute_from_key Got ddeexec L"http\\shell\\open\\ddeexec" =>
L"\"%1\",,-1,0,,,,"
trace:exec:dde_connect Launching L"C:\\windows\\system32\
\winebrowser.exe -nohome"
trace:exec:SHELL_ExecuteW Execute L"C:\\windows\\system32\
\winebrowser.exe -nohome" from directory L""
trace:exec:SHELL_ExecuteW returning 33
trace:exec:SHELL_ArgifyW 0x329128, 256, L"\"%1\",,-1,0,,,,",
L"http://www.winehq.org", (nil), 0x32c004
trace:exec:SHELL_ArgifyW used 33 of 256 space
trace:exec:dde_connect L"\"%1\",,-1,0,,,," L"http://www.winehq.org" =>
L"\"http://www.winehq.org\",,-1,0,,,,"
err:winebrowser:get_url_from_dde Unable to retrieve URL from string
L"\""
err:winebrowser:wmain Usage: winebrowser URL
trace:exec:SHELL_execute retval 33


On Sun, 2010-05-30 at 16:41 +0200, André Hentschel wrote:
> Am 29.05.2010 17:17, schrieb Joel Holdsworth:
> > Hi All,
> > 
> > I know it's late and we're in freeze mode now, but I wanted to offer
> > some work I've been doing:
> > 
> > http://www.airwebreathe.org.uk/space/new-about-screen.png
> > 
> > Basically I've been giving the about page of winecfg a face lift. It
> > seemed like a good idea to put some polish on it in time for the
> > release. Is there any interest in pushing this? or is it too late?
> 
> As Nikolay said, it is safe.
> 
> > The patches are all fairly straightforward. The only gotcha is that the
> > modification to the page layout has to be carried across all languages
> > without introducing any errors. I'm planning to do this with a simple
> > script, but is there a simple way of switching between languages
> > quickly? So I can check the layout doesn't get broken?
> > 
> > Also, if I submit these patches - to be merged now or later, would it be
> > better to submit all the resource language patches inidividually? or
> > language by language?
> > 
> > What do people think?
> 
> First: Good idea and great job! It goes with the new Icons.
> 
> Like Nikolay i am a bit scared of the link control. Maybe that should not be included in the first patch and you can send it later when it surely works.
> Against Nikolay's opinion i think you didnt changed the layout too much(compared one by one) so it is ok.
> 
> 





More information about the wine-devel mailing list