RFC: Fixing comctl32 toolbar tests for different system font heights

Austin Lund austin.lund at gmail.com
Thu Nov 4 05:20:24 CDT 2010


I'm trying to fix these test failures:

http://test.winehq.org/data/d4f64121e83671ac10ed6ead04f1c19eb5586cb0/xp_wtb-wxpprojasp3/comctl32:toolbar.html

These failures occur because the system font metrics are different to
what is assumed for the hard-coded numbers.

Attached is my go at fixing these (in a three part patch set).  Is
this approach even close to being the right way to do this?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-comctl32-tests-Change-toolbar-size-test-data-to-load.patch
Type: text/x-patch
Size: 14039 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20101104/7d4601a3/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-comctl32-tests-Added-extra-debugging-information-to-.patch
Type: text/x-patch
Size: 2166 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20101104/7d4601a3/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-comctl32-tests-Fix-toolbar-size-tests-that-depend-on.patch
Type: text/x-patch
Size: 6750 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20101104/7d4601a3/attachment-0005.bin>


More information about the wine-devel mailing list