[PATCH 4/4] mshtml: Moved tid declaration to separated file.
Jacek Caban
jacek at codeweavers.com
Mon Nov 8 05:51:41 CST 2010
On 11/8/10 11:34 AM, Alexandre Julliard wrote:
> Jacek Caban<jacek at codeweavers.com> writes:
>
>> Doing define/include tricks isn't perfect solution, but the current
>> state is even worse.
>> ---
>> dlls/mshtml/dispex.c | 93 ++---------------------------------------
>> dlls/mshtml/mshtml_private.h | 94 ++---------------------------------------
>> dlls/mshtml/tid.inc | 88 +++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 98 insertions(+), 177 deletions(-)
>> create mode 100644 dlls/mshtml/tid.inc
> Please don't create a separate file, particularly not with a
> non-standard extension. You can do this with a macro in
> mshtml_private.h.
I've resent a fixed version. Personally I find separated file nicer than
almost 100 lines, growing in size, macro.
Thanks,
Jacek
More information about the wine-devel
mailing list