wined3d: remove a useless variable
David Adam
david.adam.cnrs at gmail.com
Sun Nov 14 13:41:49 CST 2010
2010/11/14 Nikolay Sivov <nsivov at codeweavers.com>
> On 11/14/2010 22:17, David Adam wrote:
>
> if(wined3d_settings.rendertargetlock_mode == RTL_DISABLE) {
>> - static BOOL warned = FALSE;
>> - if(!warned) {
>> - ERR("The application tries to lock the render target, but
>> render target locking is disabled\n");
>> - warned = TRUE;
>> - }
>> + ERR("The application tries to lock the render target, but render
>> target locking is disabled\n");
>> return;
>> }
>>
> Why is it useless?
>
Maybe I missed something:
Since warned= False we always enter in the if condition. Then warned=TRUE.
But we leave the first if condition that is the lifetime of the variable. So
the variable is destroyed ans is useless.
Am I wrong?
A+
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20101114/0a4f5067/attachment.htm>
More information about the wine-devel
mailing list