Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status

Borut Razem borut.razem at siol.net
Sat Nov 20 04:53:52 CST 2010


On 11/18/2010 02:54 PM, Alexandre Julliard wrote
 > Yes, you need to grow it dynamically. That doesn't mean you need a 
linear search.

Here is the new patch: dynamically allocated array of process handles 
indexed by fd, no linear search.
The patch compiles without errors but I haven't done any tests yet. 
Please review it and let me know if you are satisfied with the approach. 
In case of the positive answer I'll do some testing ant let you know 
about results.

P.S.: MSVCRT_MAX_FILES is (re)defined in process.c and should be same as 
MSVCRT_MAX_FILES in file.c. It would be better to define it only once in 
a header file, for example in msvcrt.h. Do you agree?

Borut

---
  dlls/msvcrt/process.c |  101 
++++++++++++++++++++++++++++++++++++++++++++++++-
  1 files changed, 99 insertions(+), 2 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Patch-for-bug-25063-_pclose-should-wait-for-the-comm.patch
Type: text/x-patch
Size: 4557 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20101120/a73e60eb/attachment.bin>


More information about the wine-devel mailing list