[PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

Vitaliy Margolen wine-devel at kievinfo.com
Thu Nov 25 22:56:17 CST 2010


On 11/24/2010 07:19 PM, James McKenzie wrote:
> On 11/24/10 6:56 PM, Vitaliy Margolen wrote:
>> On 11/24/2010 12:23 PM, jimportal at gmail.com wrote:
>>> From: James Eder<jimportal at gmail.com>
>>>
>>> - while (fgets(line,200,f) != NULL)
>>> + while (fgets(line,450,f) != NULL)
>> You might as well then change this to "sizeof(line)".
> Just for my edification, is there not a better way then setting the variable
> line to a flexible length for this purpose.
Unless I didn't understand your question - you can't set a buffer to a 
"variable length". You have to provide fgets() a size of the buffer so it 
can read at most that many characters -1 for terminating \0.

Vitaliy.



More information about the wine-devel mailing list