[PATCH] ntdll: Increase size of buffer used to read lines of /proc/cpuinfo

James McKenzie jjmckenzie51 at earthlink.net
Fri Nov 26 08:15:26 CST 2010


On 11/26/10 12:15 AM, Damjan Jovanovic wrote:
> On Fri, Nov 26, 2010 at 6:56 AM, Vitaliy Margolen
> <wine-devel at kievinfo.com>  wrote:
>> On 11/24/2010 07:19 PM, James McKenzie wrote:
>>> On 11/24/10 6:56 PM, Vitaliy Margolen wrote:
>>>> On 11/24/2010 12:23 PM, jimportal at gmail.com wrote:
>>>>> From: James Eder<jimportal at gmail.com>
>>>>>
>>>>> - while (fgets(line,200,f) != NULL)
>>>>> + while (fgets(line,450,f) != NULL)
>>>> You might as well then change this to "sizeof(line)".
>>> Just for my edification, is there not a better way then setting the
>>> variable
>>> line to a flexible length for this purpose.
>> Unless I didn't understand your question - you can't set a buffer to a
>> "variable length". You have to provide fgets() a size of the buffer so it
>> can read at most that many characters -1 for terminating \0.
>>
>> Vitaliy.
>>
>>
>>
> So read lines dynamically instead:
>
This is exactly what I was trying to get at.  Thank you Damjan.

James McKenzie




More information about the wine-devel mailing list