winex11: remove unused field

Dmitry Timoshkov dmitry at codeweavers.com
Mon Nov 29 01:26:53 CST 2010


Ričardas Barkauskas <miegalius at gmail.com> wrote:

>  typedef struct
>  {
>      LOGFONTW lf;
> -    XFORM    xform;
>      SIZE     devsize;  /* size in device coords */
>      DWORD    hash;
>  } LFANDSIZE;
> @@ -639,7 +638,6 @@ static BOOL fontcmp(LFANDSIZE *p1, LFANDSIZE *p2)
>  {
>    if(p1->hash != p2->hash) return TRUE;
>    if(memcmp(&p1->devsize, &p2->devsize, sizeof(p1->devsize))) return TRUE;
> -  if(memcmp(&p1->xform, &p2->xform, sizeof(p1->xform))) return TRUE;
>    if(memcmp(&p1->lf, &p2->lf, offsetof(LOGFONTW, lfFaceName))) return TRUE;
>    return strcmpiW(p1->lf.lfFaceName, p2->lf.lfFaceName);
>  }

It's not useless, probably you need to check the DC graphics mode before storing
the XFORM in the cache, like dlls/gdi32/freetype.c,WineEngCreateFontInstance() is
doing.

-- 
Dmitry.



More information about the wine-devel mailing list