(resend)[2/10]winegstreamer: add gstreamer splitter filter

Aric Stewart aric at codeweavers.com
Mon Oct 25 10:51:39 CDT 2010


Ah yes.  Working to clean up someone else's code and missed that.

-aric

On 10/10/25 9:00, Vitaliy Margolen wrote:
> On 10/25/2010 07:45 AM, Aric Stewart wrote:
>> ---
>
>> + ERR("++++++++++++++++ perform byte seek ------------------\n");
>> + if (1 || This->initial) {
>> + ERR("Relinked\n");
>> + FIXME("Seeking %i %i\n", format, GST_FORMAT_BYTES);
>> + FIXME("using \"%s\"\n", name);
> Some debug leftovers?
>
>> + AM_MEDIA_TYPE amt = { };
>> ..
>> + ZeroMemory(&amt, sizeof(amt));
> This is redundant.
>
>> sizeof(piOutput.achName) / sizeof(*piOutput.achName)
> The more common construct in Wine is sizeof(array)/sizeof(array[0]).
> IMHO it's better to stick with one
>
> Also could you please put an empty line in each function after variable
> declarations? Your patches look inconsistent.
>
> Vitaliy.
>
>



More information about the wine-devel mailing list