[PATCH 3/3] include: Add MCI_INTEGER64 and MCI_INTEGER3264 mci types. (try 2)
octavian.voicu at gmail.com
Wed Sep 1 13:36:35 CDT 2010
On Wed, Sep 1, 2010 at 9:20 PM, Jacek Caban <jacek at codeweavers.com> wrote:
> On 9/1/10 7:45 PM, Octavian Voicu wrote:
>> MCI_INTEGER64 is only defined for _WIN64 in DDK.
>> MCI_INTEGER3264 is wine specific and will be needed because MCI_STATUS
>> return type is MCI_INTEGER64 in 64-bit winmm.dll, and MCI_INTEGER
>> in 32-bit winmm.dll.
> That's not a reason to add Wine-specific defines in public header.
There are two reasons for which I considered it appropriate:
1. In a future patch I will change MCI_INTEGER to MCI_INTEGER3264 in
all the *_res.rc files related to mci. They already include mmddk.h,
and there is no other private include header afaik.
2. I saw there were some other #ifdef __WINESRC__ in mmddk.h, so I
used the same pattern (I'm guessing it won't be available to
applications compiling with this header, just when compiling wine).
If this is not the correct approach, can you suggest a better one? I
definitely need a constant like MCI_INTEGER3264 to replace all the
MCI_INTEGERs in MCI_STATUS return type (adding one #ifdef for each
status command would be overkill imho).
More information about the wine-devel