Typo in : wined3d: Translate before scaling for rhw as well in transform_projection().

Joris Huizer joris_huizer at yahoo.com
Tue Sep 7 06:21:41 CDT 2010


While skimming through recently committed patches, I noticed this piece:

+        /* Window Coord 0 is the middle of the first pixel, so translate by 1/2 pixels */
+        glTranslatef(63.0f / 128.0f, 63.0f / 128.0f, 0.0f);
+        checkGLcall("glTranslatef(63.0f / 128.0f, -63.0f / 128.0f, 0.0f)");

In the checkGLcall you changed the sign of the second parameter, but you didn't do this in the glTranslatef call. 
This seemed a bit strange (and I don't know which one would be right).

HTH,
Joris


      



More information about the wine-devel mailing list