[PATCH 2/2] d3dx9: Implement D3DXCreateMesh and initial ID3DXMesh methods.

Henri Verbeet hverbeet at gmail.com
Wed Sep 8 05:37:54 CDT 2010


You have leaks in your error paths.

On 8 September 2010 02:33, Misha Koshelev <misha680 at gmail.com> wrote:
> +    /* Create vertex buffer */
> +    hr = IDirect3DDevice9_CreateVertexBuffer(device,
> +                                             numvertices * sizeof(D3DXVECTOR3) * 2,
> +                                             0, /* Usage */
> +                                             fvf,
> +                                             D3DPOOL_MANAGED,
> +                                             &vertex_buffer,
> +                                             NULL);
Tests for that would be nice. E.g., I don't believe for a second the
buffer length is really calculated that way, and does it really create
an FVF vertex buffer?



More information about the wine-devel mailing list