mshtml and friends

[Jacek Caban]

  On 9/29/10 3:03 PM, Reece Dunn wrote:
> On 29 September 2010 13:45, Jacek Caban<jacek at codeweavers.com>  wrote:
>> The
>> problem is probably somewhere else and the question is why the script takes
>> code path resulting in an exception (and even if it's supposed to do so,
>> current exception handling is probably good enough for it).
> The problem with the current wine tip is that
> 'fixme:jscript:new_expression_eval throw TypeError' line. Since this
> is triggered in the main script (not in a try ... catch block) it will
> not get handled properly.

Sure, but if you want to test new_expression_eval behavior, it's enough and 
better as the code is cleaner. OnScriptError is a separate problem.

>>> a/ dlls/jscript/tests/activex.c -- add a test_jscript_error function
>> That's not the right place. See exception_test in api.js for exceptions
>> test. It's obviously not testing OnScriptError, but most tests should go
>> there.
> This is what step (1) is testing:
>
>      exception_test(function() {new null;}, "TypeError", ...);
>
> which is great if you have something like:
>
>      <script>try { new null; } catch (e) { ... }</script>
>
> but not something like:
>
>      <script>new null;</script>
>
> This triggers (http://msdn.microsoft.com/en-us/library/shbz8x82%28v=VS.85%29.aspx)
> the IActiveScriptSite_OnScriptError callback notification. This is
> what I intend on testing in the dlls/jscript/tests/activex.c tests as
> I need to inspect that call when executing this type of
> unhandled/uncaught exception, which is what will happen in the Big
> Fish Games client.

You have run.c for that. activex.c is, as the name suggests, for testing 
ActiveXObject-related stuff.

Jacek