comctl32/tests: Remove practically unused parameters from test functions

Vitaliy Margolen wine-devel at kievinfo.com
Wed Apr 27 19:05:43 CDT 2011


On 04/27/2011 09:47 AM, Nikolay Sivov wrote:
> On 4/27/2011 17:53, Vitaliy Margolen wrote:
>> On 04/27/2011 01:14 AM, Nikolay Sivov wrote:
>>> Remove practically unused parameters from test functions
>>>
>>
>> So how is global variable any better then local variable passed as
>> function parameter?
> Because there's no need to have different parent windows for currently
> present tests. I don't see a reason of
> having window handle created exactly once and then passed in each test
> function, it's tests after all with a straightforward structure.
The reason - all global variables are bad, do not use them. Regardless why 
and how they are created and/or used.

Vitaliy.



More information about the wine-devel mailing list