mshtml: Use the last colon in proxy url as port separator

Michael Stefaniuc mstefani at redhat.com
Wed Aug 17 15:43:13 CDT 2011


On 08/17/2011 10:31 PM, André Hentschel wrote:
> Am 17.08.2011 22:18, schrieb Juan Lang:
>> Hi André,
>>
>>> http://domain\user:password@server.com:8080 makes it visible that it's intended to get the last colon
>>
>> What about http://domain\user:password@server.com?  password isn't the
>> port number.
>> --Juan
> 
> in case password is not a number atoi would fail and everythings fine :)
> so yes, if password is a number we get in trouble, so we need a better check
Is the ProxyServer specified as an URL? If yes then use the proper API
to dissect the URL instead of cobbling something together.

bye
	michael



More information about the wine-devel mailing list