mscoree: COM cleanup for the ICLRRuntimeInfo iface.

Michael Stefaniuc mstefani at redhat.com
Fri Aug 19 05:16:16 CDT 2011


For those interested in coccinelle

Michael Stefaniuc wrote:
> On 08/18/2011 03:29 PM, Dan Kegel wrote:
>> Seems to cause a test failure here?
> Argh, indeed!
> - (IUnknown*)&runtimes[i]
> + &runtimes->ICLRRuntimeInfo_iface
> 
> The array subscript got dropped and that wasn't a manual change. Need to
> check if I'm hitting a bug in coccinelle or just a "feature".
It was a feature aka I got bitten by the "ptr_to_array" isomorphism.
Disabling that in the respective rule fixed it.

bye
	michael

>> make[1]: Entering directory
>> `/home/dank/wineslave.dir/sandbox/slave/runtests/build/dlls/mscoree/tests'
>> ../../../tools/runtest -q -P wine -M mscoree.dll -T ../../.. -p
>> mscoree_test.exe.so metahost.c && touch metahost.ok
>> metahost.c:135: Test failed: got unexpected version L"v1.1.4322"
>> fixme:mscoree:CLRMetaHost_GetRuntime Unrecognized version L"v2.0.0"
>> Command exited with non-zero status 1
>> 0.04user 0.03system 0:00.09elapsed 82%CPU (0avgtext+0avgdata 27104maxresident)k
>> 0inputs+0outputs (0major+5905minor)pagefaults 0swaps
>> make[1]: *** [metahost.ok] Error 1
>> ../../../tools/runtest -q -P wine -M mscoree.dll -T ../../.. -p
>> mscoree_test.exe.so mscoree.c && touch mscoree.ok
>> mscoree.c:140: Test failed: version is L"v1.1.4322" , expected L"v2.0.50727"
>> mscoree.c:145: Test failed: version is L"v1.1.4322" , expected L"v2.0.50727"
>> fixme:mscoree:CreateConfigStream ((null), 0x32fbb4): stub
>> fixme:mscoree:CreateConfigStream
>> (L"Z:\\home\\dank\\wineslave.dir\\sandbox\\slave\\runtests\\build\\dlls\\mscoree\\tests\\conf.xml",
>> (nil)): stub
>> fixme:mscoree:CreateConfigStream ((null), (nil)): stub
>> fixme:mscoree:CreateConfigStream (L"nonexist.xml", 0x32fbb4): stub
>> fixme:mscoree:CreateConfigStream
>> (L"Z:\\home\\dank\\wineslave.dir\\sandbox\\slave\\runtests\\build\\dlls\\mscoree\\tests\\conf.xml",
>> 0x32fbb4): stub
>> Command exited with non-zero status 2
>> 0.05user 0.02system 0:00.09elapsed 81%CPU (0avgtext+0avgdata 27296maxresident)k
>> 0inputs+8outputs (0major+5969minor)pagefaults 0swaps
>> make[1]: *** [mscoree.ok] Error 2
>> make[1]: Target `test' not remade because of errors.
>>
>> (Log at http://buildbot.kegel.com:8010/builders/runtests/builds/32 for
>> a day or so.)



More information about the wine-devel mailing list