kernel32: Improve GetVolumeInformation filesystem flags I set flags value according to my tests which may differ from a windows version to another.
GOUJON Alexandre
ale.goujon at gmail.com
Mon Aug 29 07:41:07 CDT 2011
On 08/29/2011 04:46 AM, Dan Kegel wrote:
> Fails to build here, since it depends on the patch "include/winnet.h:
> Add more GetVolumeInformation system flags",
> but you didn't mark them as being part of a series.
> See "Subject Line" in http://wiki.winehq.org/SubmittingPatches
>
> volume.c: In function ‘GetVolumeInformationW’:
> volume.c:672: error: ‘FILE_SUPPORTS_REPARSE_POINTS’ undeclared (first
> use in this function)
> volume.c:672: error: (Each undeclared identifier is reported only once
> volume.c:672: error: for each function it appears in.)
> volume.c:672: error: ‘FILE_SUPPORTS_SPARSE_FILES’ undeclared (first
> use in this function)
> volume.c:672: error: ‘FILE_VOLUME_QUOTAS’ undeclared (first use in
> this function)
> make[1]: *** [volume.o] Error 1
>
> You probably also want to use shorter subject lines,
> and move more of the patch description into the body
> of your message.
>
When I wrote the description of the patch using git commit, I wrote
"kernel32: Improve GetVolumeInformation filesystem flags" as the title
and the remaining part on a new line (to make it a comment).
If I look at my commit with GitWeb locally, the title is short and my
comment is on a separate line.
I'm probably missing something.
Do you know how to "move [...] description into the body" (except manual
editing before sending them) ?
And concerning your first remark, I forgot the -n parameter to git
format-patch.
But before resending my patches, I would fix this long-subject-line issue.
More information about the wine-devel
mailing list