comctl32/tests: Use a function instead of a macro for CheckSize test

Vitaliy Margolen wine-devel at kievinfo.com
Tue Feb 8 19:13:35 CST 2011


On 02/08/2011 04:45 PM, EG Galano wrote:
> This fixes the warnings:
> comctl32/tests/tab.c:525: warning: logical `&&' with non-zero constant
> will always evaluate as true
> comctl32/tests/tab.c:545: warning: logical `&&' with non-zero constant
> will always evaluate as true
> comctl32/tests/tab.c:568: warning: logical `&&' with non-zero constant
> will always evaluate as true
> comctl32/tests/tab.c:1015: warning: logical `&&' with non-zero
> constant will always evaluate as true
>
> for me on Debian gcc 4.3.2
Time to file bug for the compiler. Yes macro looks bad and that's not the 
way I would have done it now, but there is not a single place where 
"non-zero constant" is used directly with logical AND.

Also what Nikolay said.

Vitaliy.



More information about the wine-devel mailing list