d3dx9: Implement D3DXFloat16to32Array and D3DXFloat32to16Array.

David Laight david at l8s.co.uk
Wed Feb 9 11:53:44 CST 2011


On Tue, Feb 08, 2011 at 01:02:36PM +0800, Dmitry Timoshkov wrote:
> > +static inline float float_16_to_32(const unsigned short *in) {
> 
> ...  Also placing a brace on its own line would follow the style
> of other functions.

The brace goes in column 1 so that [[ and ]] work in vi.
Putting the function name in column 1 lets you search for the
definition using the anchored regexp ^function_name\>

Putting { and } on the same lines as for, while and else avoids problems
like determining whether this is intended to be the bottom or top of a loop:
	bar = 1;
    }
    while (very long conditional expression that is truncated by the ...
    {
	int foo;

and whether there is an else on the line you can't see below the bottom
of the window when you can see:
    if (...)
    {
	...
    }
The 'else' problem is much worse if you are looking at a printout
on fanfold paper,

	David

-- 
David Laight: david at l8s.co.uk



More information about the wine-devel mailing list