[PATCH 01/13] dsound: New sample rate converter core functions.
knik00 at gmail.com
Fri Feb 11 05:16:09 CST 2011
2011/2/11 Dmitry Timoshkov <dmitry at codeweavers.com>:
> Krzysztof Nikiel <knik00 at gmail.com> wrote:
>> > You can't send Makefile changes separately from added/removed
>> > files, a patch should not add dead code.
>> Could you explain "dead code", all 13 parts need to be applied,
>> otherwise the code will be broken.
> Wine should compile and be able to pass 'make test' after each separate patch.
> You can't add for instance dlls/dsound/resample.c in one patch, and add it to
> Makefile or use interfaces provided by it in some later patches. Every patch
> should be finished and self-containing.
Well, previous version of this patch was rejected as "needs
splitting", it's basically too big to be send as a single patch. It
can be applied as several smaller chunks or rejected as a whole. I
don't think there is any other option.
More information about the wine-devel