comctl32: Add missing break (Coverity)

[Nikolay Sivov]

On 2/23/2011 19:28, Amine Khaldi wrote:
> CIDs 1581 and 1583.
> @@ -1852,6 +1852,7 @@ COMBOEX_EditWndProc (HWND hwnd, UINT uMsg, 
> WPARAM wParam, LPARAM lParam,
>
>          case VK_UP:
>          step = -1;
> +        break;
>          case VK_DOWN:
>          /* by default, step is 1 */
>          oldItem = SendMessageW (infoPtr->hwndSelf, CB_GETCURSEL, 0, 0);
This is wrong.

> @@ -2297,6 +2297,7 @@ static LRESULT 
> TOOLBAR_Cust_AvailDragListNotification(const CUSTDLG_INFO *custIn
>              TOOLBAR_Cust_AddButton(custInfo, hwnd, nIndexFrom, nIndexTo);
>          }
>      }
> +    break;
>      case DL_CANCELDRAG:
>          /* Clear drag arrow */
>          DrawInsert(hwnd, hwndList, -1);
Why? Looks to me it's fine to clear on dropped case too. Coverity is a 
bit paranoid about missed breaks.

Also don't include completely unrelated changes to one patch.
>
> Regards,
> Amine.
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110223/d7ef6319/attachment.htm>