[PATCH 1/2] user32: make DIB_GetBitmapInfo checks stricter
Alexandre Julliard
julliard at winehq.org
Wed Feb 23 12:23:21 CST 2011
Wolfram Sang <wolfram at the-dreams.de> writes:
> @@ -988,6 +988,9 @@ static void test_LoadImage(void)
> bmpimage[0x18]++; /* biWidth > 65535 */
> test_LoadImageFile("BMP (too wide)", bmpimage, sizeof(bmpimage), "bmp", 0);
> bmpimage[0x18]--;
> + bmpimage[0x11]++; /* biSize > 2^24 */
> + test_LoadImageFile("BMP (broken biSize)", bmpimage, sizeof(bmpimage), "bmp", 0);
> + bmpimage[0x11]--;
That's not a very convincing test. You should test more interesting
sizes like intermediate values, off-by-one, etc.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list