Test timeouts

[Alexandre Julliard]

Greg Geldorp <ggeldorp at vmware.com> writes:

>> From: Alexandre Julliard
>>
>> I think it would be better to make the test detect such an environment
>> and have it skip some things if it finds that it's taking too long.
>
> I guess that's what we currently have... In effect, if it takes too long,
> the final tests are skipped. I was hoping we could do better than that.

The difference is that a test killed by a timeout is considered an
error, because it's not supposed to happen. If the test knows that it
can happen it should take measures to prevent it.

I don't think increasing the timeout is a solution, because there's no
clear value for what the maximum should be, so to be safe you have to
make it way too long. There are already cases where I apply patches
without waiting for the testbot to check them, because it's busy with
some other test that's timing out (of course the testbot having a 5
minutes timeout makes this worse). We really need to enforce that tests
finish in a reasonable time.

-- 
Alexandre Julliard
julliard at winehq.org