crypt32: Added Quoting-Tests
Juan Lang
juan.lang at gmail.com
Tue Jan 11 09:18:58 CST 2011
Hi Christian,
-static BYTE bin1[] = { 0x55, 0x53 };
-static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74,
+static BYTE bin1[] = { 0x55, 0x53 };
+static BYTE bin2[] = { 0x4d, 0x69, 0x6e, 0x6e, 0x65, 0x73, 0x6f, 0x74,
0x61 };
Please don't introduce whitespace-only changes, it's harder to see
what your patch is doing.
+ { "0", CERT_RDN_PRINTABLE_STRING,
+ { sizeof(bin9), bin9 }, "abc\"def" },
Since these changes pass on unpatched wine, they don't demonstrate the
necessity for your patch. We need tests that show what the existing
problem is.
--Juan
More information about the wine-devel
mailing list