[02/10] ntdll/tests: Avoid casting away const and avoid potential overflows in comparison functions.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
http://testbot.winehq.org/JobDetails.pl?Key=8309

Your paranoid android.


=== WNT4WSSP6 (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== W2KPROSP4 (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== WXPPROSP3 (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== W2K3R2SESP2 (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== WVISTAADM (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== W2K8SE (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== W7PRO (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== W7PROX64 (32 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is World
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Hopefully
string.c:1232: Test failed: badly sorted, strarr[3] is .
string.c:1233: Test failed: badly sorted, strarr[4] is Hello
string.c:1235: Test failed: badly sorted, strarr[6] is Sorted

=== W7PROX64 (64 bit string) ===
string.c:1229: Test failed: badly sorted, strarr[0] is Hello
string.c:1230: Test failed: badly sorted, strarr[1] is !
string.c:1231: Test failed: badly sorted, strarr[2] is Wine
string.c:1232: Test failed: badly sorted, strarr[3] is World
string.c:1233: Test failed: badly sorted, strarr[4] is Hopefully
string.c:1234: Test failed: badly sorted, strarr[5] is Sorted
string.c:1235: Test failed: badly sorted, strarr[6] is .