ntdll/cdrom : implement CDROM_Verify to work on Mac OS X, with comment (try 3)

Henri Verbeet hverbeet at gmail.com
Mon Jan 24 17:51:22 CST 2011


On 25 January 2011 00:29, Ken Thomases <ken at codeweavers.com> wrote:
> Your mailer seems to have mangled your patch with line wrapping.  There are some suggestions on Wine's SubmittingPatches wiki page for avoiding this.  Primarily, you should attach the patch to your email.  If you already did that, then you may need to use a different mailer.  For example, Mail.app used to mess up even attached patches, although it doesn't for me anymore.  (I don't know if that's because Mail.app changed or if git-format-patch changes.)  When it used to be a problem, I had to use Thunderbird to send my Wine patches.
>
Just use git format-patch for sending patches, if possible. Mail
clients are just terrible, and using git format-patch avoids a lot of
the common issues. If you send more than one or two patches it's
usually faster too.




More information about the wine-devel mailing list