shell32: Remove dead assignments (Clang)
Nikolay Sivov
bunglehead at gmail.com
Wed Jul 6 04:00:59 CDT 2011
2011/7/6 Frédéric Delanoy <frederic.delanoy at gmail.com>:
> ---
> dlls/shell32/shelllink.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c
> index 07fe7aa..fff0e79 100644
> --- a/dlls/shell32/shelllink.c
> +++ b/dlls/shell32/shelllink.c
> @@ -1189,29 +1189,29 @@ static HRESULT WINAPI IPersistStream_fnSave(
> Stream_WriteLocationInfo( stm, This->sPath, &This->volume );
>
> if( This->sDescription )
> - r = Stream_WriteString( stm, This->sDescription );
> + Stream_WriteString( stm, This->sDescription );
>
This is questionable. If you write to a provided stream it's ok for it
to fail write operation, this needs a test. Method return value should
probably reflect write failure.
More information about the wine-devel
mailing list