[PATCH 4/4] winmm: Fix check for DCB_NULL callback type
Joerg-Cyril.Hoehle at t-systems.com
Joerg-Cyril.Hoehle at t-systems.com
Wed Jul 20 07:28:13 CDT 2011
Andrew Eikum wrote:
>- if(info->flags & DCB_NULL)
>+ if((info->flags & DCB_TYPEMASK) == DCB_NULL)
Instead of add ing a special case, I suggest to simplify the code: always call DriverCallback and declare
void WINMM_NotifyClient. You currently ignore its return value anyway.
Using void is consistent with an ealier notification patch of mine around April this year.
Michael,
wouldn't it be possible to add a function to the static checkers to be able
to detect static functions whose return is systematically ignored and rewrit these and their callers to use void?
I came across another occurence of that pattern no later than yesterday (mcimidi IIRC).
Regards,
Jörg Höhle
More information about the wine-devel
mailing list