d3d8/tests: make sure to use return values (LLVM/Clang)
hverbeet at gmail.com
Tue Jul 26 10:22:35 CDT 2011
On 26 July 2011 16:57, Jacek Caban <jacek at codeweavers.com> wrote:
> Seriously, I'm not talking about anything like that. We get to choose
> between using two things. SUCCEDEED() has no advantages over testing
> exact values in this context. Testing the exact value has a small, but
> still, advantage. I believe we agree on this. Then if you have a choice,
No, I disagree with the basic idea that stricter tests are necessarily
better. The advantage of SUCCEEDED is that it's *less* strict.
That said, the specific issue is insignificant enough that I wouldn't
care about e.g. a new test using "hr == D3D_OK". I just don't think
that changing existing tests from SUCCEEDED to "hr == D3D_OK" is
really an improvement.
More information about the wine-devel