Re: GSoC-2011: Implement Missing Mesh Functions in Wine’s D3DX9

[Michael Mc Donnell]

On Wed, Jun 8, 2011 at 12:59 PM, Henri Verbeet <hverbeet at gmail.com> wrote:
> On 8 June 2011 11:33, Michael Mc Donnell <michael at mcdonnell.dk> wrote:
>> Henri, do you have any comments about my UpdateSemantics patches
>> before I send them off to wine-patches?
>>
> Looks fine to me.

Good :-)

> On the subject of style though, two things:
>  - I really dislike things like LPDWORD and LPD3DXMESH. For one,
> there's the issue that "const LPDWORD" doesn't do what you want, so
> you'd need something like "LPCDWORD", which doesn't exist. The other
> issue is that unless typedefs are used for some kind of abstraction,
> like e.g. uint32_t, they're just obfuscation. I.e., "typedef type
> *LPTYPE;" just hides that "LPTYPE" is a pointer, and "typedef
> enum/struct x x;" just hides that "x" is a struct or enum.

Thank you for the explanation. I've changed those.

>  - "There’s a standard naming scheme for C, and it’s all lower case
> with underscores as separators."

Ah yes, I've been writing too much C++ and C# lately :-) I've changed that too.

I've also moved the declaration of a vertex struct inside the test
function, as it was not needed outside of the test function.

Thank you for your comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-d3dx9-test-Added-UpdateSemanticsTest.patch
Type: text/x-patch
Size: 11135 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110608/441e0c78/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-d3dx9-Implemented-UpdateSemantics-mesh-method.patch
Type: text/x-patch
Size: 7810 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110608/441e0c78/attachment-0003.bin>