[PATCH] wined3d: Dont just print a FIXME on error, handle it (Coverity)

Stefan Dösinger stefan at codeweavers.com
Sat Jun 11 04:52:04 CDT 2011


On Saturday 11 June 2011 11:17:58 Marcus Meissner wrote:
>      else
> +    {
>          FIXME("Unhandled transform state %#x.\n", state);
> +        return WINED3DERR_INVALIDCALL;
> +    }
Please return WINED3D_OK, like wined3d_device_set_sampler_state and other 
setters. Native doesn't do this kind of consistency checking, so apps will get 
D3D_OK returned if they pass an out of range state(unless the setter 
segfaults).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110611/f03d81f6/attachment.pgp>


More information about the wine-devel mailing list