[PATCH 2/5] ddraw: Adjust reference counts of created surfaces in ddraw_set_surface_version.
Henri Verbeet
hverbeet at gmail.com
Wed Jun 15 05:49:43 CDT 2011
2011/6/14 <rbarkauskas at codeweavers.com>:
> + switch(version)
> + {
> + case 4:
> + IDirectDrawSurface4_AddRef(&surface->IDirectDrawSurface4_iface);
> + break;
> + case 3:
> + case 2:
> + case 1:
> + IDirectDrawSurface_AddRef(&surface->IDirectDrawSurface_iface);
> + break;
> + }
> + IDirectDrawSurface7_Release(&surface->IDirectDrawSurface7_iface);
Why do you need this here instead of in the relevant surface creation
functions? (I suppose because of the mipmaps, but I think it may be
better to do all this when the surface is created instead of
afterwards.)
More information about the wine-devel
mailing list