[PATCH 1/3] user32/tests: Added client-side raw input function tests (try 5 resend)

Vincas Miliūnas vincas.miliunas at gmail.com
Sun Jun 26 11:41:11 CDT 2011


On 06/22/2011 06:26 PM, André Hentschel wrote:
> Am 22/06/2011 06:26, schrieb Vincas Miliūnas:
>> +    if (pDefRawInputProc && pGetRawInputBuffer && pGetRawInputData
&& pGetRawInputDeviceList &&
>> +        pGetRawInputDeviceInfoA && pGetRawInputDeviceInfoW &&
pGetRegisteredRawInputDevices && pRegisterRawInputDevices)
>
> You should avoid such a construct, move the check to test_functions
that actually need these functions.
> e.g. check for pGetRawInputBuffer only in test_get_raw_input_buffer
> i didn't looked very close, but if the tests depend on each other
there should be a comment.
> the rest of that patch looks fine to me

Done - http://source.winehq.org/patches/data/75756




More information about the wine-devel mailing list