wined3d/device: Avoid repeated calculations of idx and shift in IWineD3DDeviceImpl_MarkStateDirty(). (resend)
amartinson at codeweavers.com
Wed Mar 16 15:09:02 CDT 2011
On 03/16/2011 02:55 PM, Alexandre Julliard wrote:
> Adam Martinson<amartinson at codeweavers.com> writes:
>> On 03/16/2011 02:24 PM, Alexandre Julliard wrote:
>>> Adam Martinson<amartinson at codeweavers.com> writes:
>>>> Look at any d3d app with oprofile. That function is called
>>>> EVERYWHERE. In my testing this reduces
>>>> IWineD3DDeviceImpl_MarkStateDirty() from 4.8% of wined3d CPU time to
>>> What compiler are you using? I don't see any difference here.
>> GCC 4.4.5, running the 3DMark06 batch size tests.
> I don't see any difference with 4.4.5 either, the generated code is
> basically identical. If gcc really doesn't notice the loop invariant for
> you, something is wrong with your setup.
Oh wow... you're correct, I'm retarded xD I have another patch that
overwrites these changes, and didn't bench them separately LOL xD Very
More information about the wine-devel