[PATCH] Label verbosity levels.
Vitaliy Margolen
wine-devel at kievinfo.com
Sat Mar 19 17:32:44 CDT 2011
On 03/18/2011 09:24 PM, max at mtew.isa-geek.net wrote:
> - if ($opt_verbose> 0)
> - {
> - print "Processing ".$spec_name."\n";
> - }
> + print "Processing ".$spec_name."\n"
> + if $opt_verbose>= $VERBOSE_INPUT;
Please don't do this reverse notation. It's much more confusing to most
people who are not too familiar with Perl.
Also you changing logic, by replacing ">" (greater then) with ">=" (greater
of equal. This is a big no-no to combine any logical changes with cleanup
changes.
More information about the wine-devel
mailing list