wined3d: check for ARB_fragment_program in arbfp_blit_supported

Roderick Colenbrander thunderbird2k at gmail.com
Sat Mar 26 10:25:00 CDT 2011


On Sat, Mar 26, 2011 at 2:18 AM, Stefan Dösinger <stefandoesinger at gmx.at> wrote:
>
> <0001-wined3d-check-for-ARB_fragment_program-in-arbfp_blit.patch>
>
> Considering this statement in select_blit_implementation, directx.c:
>     if ((ps_selected_mode == SHADER_ARB || ps_selected_mode == SHADER_GLSL)
>             && gl_info->supported[ARB_FRAGMENT_PROGRAM]) return &arbfp_blit;
>     else return &ffp_blit;
> How does wined3d end up using arbfp_blit?
>
>

For some more background see the thread 'wined3d: Prevent crash when
blit_priv is NULL' started by Konrad Rzepecki . Essentially because
the blitter refactoring is not finished, BltOverride can enter this
code. Inside BltOverride there is a 'arb_blit_supported' which at this
point returned TRUE, which allowed calling of arb_blit_surface.

Roderick



More information about the wine-devel mailing list