comctl32: realloc or free and alloc

[Nikolay Sivov]

On 5/1/2011 13:07, Alexey Fisher wrote:
>
> There is a new patch in the attachment.

>   BOOL Str_SetPtrAtoW (LPWSTR *lppDest, LPCSTR lpSrc)
>   {
> -    TRACE("(%p %s)\n", lppDest, lpSrc);
> +    TRACE("(%p, %s)\n", *lppDest, debugstr_a(lpSrc));
> +
> +    if (*lppDest) {
> +        ERR("lppDest should be NULL!");
> +        return FALSE;
> +    }
It's an internal call, so it's better to require a caller to pass valid 
parameters. That's why ERR is too much here, cause you completely 
control passed parameters in a first place.

Please open a bug with a test C application so we can look at initial 
problem.