[PATCH 1/2] ddraw: COM cleanup for IDirectDrawSurface3 iface

Michael Stefaniuc mstefani at redhat.com
Wed May 25 04:09:32 CDT 2011


Hello Ričardas!

Ričardas Barkauskas wrote:
> My first try for COM cleanup. Please donėt be too harsh :)
> If this is too large for one patch, please suggest how to split it.
> 
> This is not automatic clean up so I don't really expect it to be good on
> first try.
Heh! I have attached the raw diff generated by my coccinelle script.
Looking at the interdiff between the two patches it looks like you
caught everything. And the BADBADBAD() (*) from the generated patch are
replaced with unsafe_impl_from_IDirectDrawSurface3(), very good.

If you want to do more COM cleanup I can give you the raw generated
patches to save you some time.

bye
	michael

P.S.: (*) My script validates that impl_from_IFace() is called only from
methods of that IFace. All other impl_from_IFace() calls are replaced
with BADBADBAD().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: IDirect3DDevice3Vtbl.diff
Type: text/x-patch
Size: 31802 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20110525/25eea09e/attachment-0001.bin>


More information about the wine-devel mailing list