advapi: test and fix GetUserName() in case where buffer is too small

Hans Leidekker hans at codeweavers.com
Tue May 31 08:17:44 CDT 2011


On Tue, 2011-05-31 at 06:32 -0500, Andrew Nguyen wrote:

> -    DWORD sizeW = *lpSize * 2;
> +    DWORD sizeW = 0;
> +
> +    GetUserNameW( NULL, &sizeW );

Can we avoid the extra call?

> I didn't intend to scoop Dan's work, but I have a version of his fix,
> which is attached, with deeper tests which I wrote before Hans expressed
> his concerns. Should I just send in the tests with todo_wine and let Dan
> fix those, or should I send a revised version and allow a "winner" to be
> picked?

I vote for getting some tests in first.





More information about the wine-devel mailing list