[PATCH 1/5] wined3d: Don't apply fixups to converted surfaces.

Stefan Dösinger stefandoesinger at gmx.at
Fri Nov 25 12:50:47 CST 2011


Am Donnerstag, 24. November 2011, 22:52:32 schrieb Henri Verbeet:
> +    if (surface->flags & SFLAG_CONVERTED)
> +    {
> +        ENTER_GL();
> +        glEnable(textype);
> +        checkGLcall("glEnable(textype)");
> +        LEAVE_GL();
> +        return WINED3D_OK;
> +    }
I don't think this is correct. E.g. signed formats without 
GL_NV_texture_shader have load time and read time fixups and both have to be 
applied.

What exactly are you trying to fix? I assume it is something about P8 blits, 
but P8->P8 blits don't enter the ARB blitting code(due to the dest fixup 
check), and I don't know of any app that uses P8->RGB or SNORM->UNORM blits.

Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20111125/3a057e0a/attachment.pgp>


More information about the wine-devel mailing list