[PATCH] kernel32: implement GetLogicalProcessorInformation
claudio.fontana at gmail.com
Fri Nov 25 13:35:58 CST 2011
On Fri, Nov 25, 2011 at 8:01 PM, Charles Davis <cdavis at mymail.mines.edu> wrote:
> On Nov 25, 2011, at 8:17 AM, Claudio Fontana wrote:
>> On Fri, Nov 25, 2011 at 4:07 PM, Claudio Fontana
>> <claudio.fontana at gmail.com> wrote:
>>> I have resent the patch as a "try 2" (there was a try 1.5 to fix test
>>> issues under windows older than XP SP3).
>>> The patch contains changes based on your feedback.
>> Which is completely broken, since the U() macro you suggested to use
>> is a wine/test.h feature only,
>> and completely broke the patch.
> You are right. The way most files (other than tests) in Wine deal with that is that they unconditionally define NONAMELESSUNION and NONAMELESSSTRUCT. So you wouldn't use U(buffer[i]) (except in the tests, where you can do that), you'd use buffer[i].u .
>> So I fall back to my try 1.5 for my tree.
> OK, you do that. I'm pretty sure AJ won't take your patch anyway until it's done "right" (i.e. like I said, in ntdll). I guess I'll take that up, since I have nothing better to do ;).
That's great! When it's done it will be one less out of tree patch to
maintain, always a win.
More information about the wine-devel