mshtml: Implement IHTMLDOMNode replaceChild

Jacek Caban jacek at codeweavers.com
Fri Oct 7 11:17:04 CDT 2011


Hi Alistair,

On 10/7/11 4:50 AM, Alistair Leslie-Hughes wrote:
> +    HTMLDOMNode *nodeNew;
> +    HTMLDOMNode *nodeOld;

Please use names consistent with the rest of the file.

+    if(NS_FAILED(nsres)) {
+        nsnode = nodeNew->nsnode;
+    }


That seems questionable, why do you pretend to success on failure?

Jacek



More information about the wine-devel mailing list