jscript: Mark some fall-throughs in switch statements

Andrew Talbot Andrew.Talbot at talbotville.com
Sat Oct 8 13:52:50 CDT 2011


> Isn't it that way just to save the use of an extra return S_OK?
> Instead a break could be used too because that function returns S_OK
> by default.
> 
> http://source.winehq.org/source/dlls/jscript/regexp.c#L4025
> 
> Best regards,
> Bruno

A fall-through would indeed be lazy and not in the spirit of the fact that
DISPATCH_PROPERTYGET and DISPATCH_PROPERTYPUT are kind of the opposite of
each other. It either requires a break in both places (for consistency)
to the common "return S_OK" or two immediate such returns, instead.

-- 
Andy.




More information about the wine-devel mailing list