80186: [PATCH 2/2] dinput: Restore checks for DirectX 3 buffer size.

Vitaliy Margolen wine-devel at kievinfo.com
Thu Oct 20 19:32:32 CDT 2011


On 10/20/2011 06:26 PM, Vitaliy Margolen wrote:
> On 10/20/2011 06:18 PM, Dan Kegel wrote:
>> On Thu, Oct 20, 2011 at 5:15 PM, Vitaliy Margolen
>> <wine-devel at kievinfo.com> wrote:
>>>>> device.c:117: Test failed: GetDeviceData() should have failed: 80040207
>>>>> device.c:120: Test failed: GetDeviceData() should have failed: 80040207
>>>>> make: *** [device.ok] Error 8
>>>
>>> Could be because of definition problems. Here's what I get compiling wine64:
>>> ../../../../wine.git/dlls/dinput/tests/device.c:117:5: warning: comparison
>>> is always false due to limited range of data type
>>> ../../../../wine.git/dlls/dinput/tests/device.c:120:5: warning: comparison
>>> is always false due to limited range of data type
>>>
>>> HRESULT defined as "typedef LONG HRESULT;". But error code defined as:
>>> #define DIERR_NOTBUFFERED 0x80040207L
>>>
>>> Not sure what to do here. Test passed on all win64 bit platforms according
>>> to test bot. So unless we want to redefine all LONG constants in PSDK (and
>>> remove that last L) I'd say ignore this.
>>
>> How can we ignore it? Once we check it in, the 64 bit build will
>> start failing its tests :-(
>
> So you saying we should modify all long error constants in PSDK? I'm not
> sure what else can be done.
>
Ok, casting error code to HRESULT seemed to work.

Vitaliy.



More information about the wine-devel mailing list