winmm: Avoid casting return value of Heap(Re)Alloc calls.

Jerome Leclanche adys.wh at gmail.com
Sun Oct 23 08:02:38 CDT 2011


2011/10/23 Dan Kegel <dank at kegel.com>:
> 2011/10/22 Frédéric Delanoy <frederic.delanoy at gmail.com>:
>> OK thx. Should probably restructure that section as well (and add
>> -Werror to my CFLAGS)
>
> How would people feel if configure turned on -Werror
> when it's safe to if building from git?  Something like this:
>
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1715,6 +1715,16 @@ then
>   if test "x$enable_maintainer_mode" = "xyes"
>   then
>       WINE_TRY_CFLAGS([-Werror])
> +  else
> +    dnl Enable -Werror when building from git on 32 bit x86 with gcc
> +    case $host_cpu in
> +      *i[[3456789]]86*)
> +        if test "x${GCC}" = "xyes" && test -d $srcdir/.git
> +        then
> +          WINE_TRY_CFLAGS([-Werror])
> +        fi
> +      ;;
> +    esac
>   fi
>
>   dnl Check for ms_hook_prologue support

It's still unsafe, you're limited to a subset of gcc versions. Not worth it.

JL



More information about the wine-devel mailing list